My company hired an outsourced "enhancement" team to add some ajax stuff to a few pages. Stuff that my team could have done, but didn't have the time/bandwidth.

Its some of the worst code  I've ever seen.

 Behold:

  if(document.getElementById('tdZipButton')!=null)
                    {
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace('id="zipCode_btnAjaxContinue"','id="zipCode_btnAjaxContinue" onclick="return CheckZipClick()"')
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace("id='zipCode_btnAjaxContinue'","id='zipCode_btnAjaxContinue' onclick='return CheckZipClick()'")                      
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace('ID="zipCode_btnAjaxContinue"','ID="zipCode_btnAjaxContinue" onclick="return CheckZipClick()"')
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace("ID='zipCode_btnAjaxContinue'","ID='zipCode_btnAjaxContinue' onclick='return CheckZipClick()'")                      
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace("id=zipCode_btnAjaxContinue","id='zipCode_btnAjaxContinue' onclick='return CheckZipClick()'")
                    }

 Theres about 10 WTF's right there. Imagine seeing 300-400 lines like this.

The Real WTF(tm) is that they could have simply written

if(document.getElementById('tdZipButton'))

How about not having to use GetElementById everytime they reference the element.

 Why are they using the parent Elements innerHTML property and replace method to change attributes on a child element. What horrible break in logic would make anyone think thats a good idea.

Also, the child element DOES have a unique ID!

Jonathan Holland:

My company hired an outsourced "enhancement" team to add some ajax stuff to a few pages. Stuff that my team could have done, but didn't have the time/bandwidth.

Its some of the worst code  I've ever seen.

 Behold:

  if(document.getElementById('tdZipButton')!=null)
                    {
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace('id="zipCode_btnAjaxContinue"','id="zipCode_btnAjaxContinue" onclick="return CheckZipClick()"')
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace("id='zipCode_btnAjaxContinue'","id='zipCode_btnAjaxContinue' onclick='return CheckZipClick()'")                      
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace('ID="zipCode_btnAjaxContinue"','ID="zipCode_btnAjaxContinue" onclick="return CheckZipClick()"')
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace("ID='zipCode_btnAjaxContinue'","ID='zipCode_btnAjaxContinue' onclick='return CheckZipClick()'")                      
                        document.getElementById('tdZipButton').innerHTML=document.getElementById('tdZipButton').innerHTML.replace("id=zipCode_btnAjaxContinue","id='zipCode_btnAjaxContinue' onclick='return CheckZipClick()'")
                    }

 Theres about 10 WTF's right there. Imagine seeing 300-400 lines like this.

What do you expect from a bunch of sand people?  Have you seen them attempt simple html?  I don't think they know what a close html tag is.  

No need to be racist. I've worked with some excellent indian programmers. The good ones come here. The crappy ones tend to stay there.

Here is my fix:

 var zipCodebtnAjaxContinue = document.getElementById('zipCode_btnAjaxContinue');
                   
                    if (zipCodebtnAjaxContinue)
                    {
                        zipCodebtnAjaxContinue.onClick = CheckZipClick();
                    }

Lysis:

What do you expect from a bunch of sand people?  Have you seen them attempt simple html?  I don't think they know what a close html tag is.

Sand people? You do realise there are more than one places outside your little part of the world, right? It's not all sand populated with people that write bad code and hate you. I know that's all you see on the news, but somehow they have neglected to tell you that there are a few billion people out there going about their business. Hell, a lot of them are far more competent developers than you or me.

I've studied with indian people during my Comp Sci degree and I can guarantee you they can do far more than close a HTML document

Jonathan Holland:

Here is my fix:

 var zipCodebtnAjaxContinue = document.getElementById('zipCode_btnAjaxContinue');
                   
                    if (zipCodebtnAjaxContinue)
                    {
                        zipCodebtnAjaxContinue.onClick = CheckZipClick();
                    }

TRWTF

DOA:

Lysis:

What do you expect from a bunch of sand people?  Have you seen them attempt simple html?  I don't think they know what a close html tag is.

Sand people? You do realise there are more than one places outside your little part of the world, right? It's not all sand populated with people that write bad code and hate you. I know that's all you see on the news, but somehow they have neglected to tell you that there are a few billion people out there going about their business. Hell, a lot of them are far more competent developers than you or me.

I've studied with indian people during my Comp Sci degree and I can guarantee you they can do far more than close a HTML document

I'm sure there will be plenty of people who will tell me about the few Injuns they know who are really goood good coderz!!!!1!!!  We all know that stereotype comes from truth.  Using your scenario, you do realize that outside of those few Injuns you have interacted with that there are millions of crappy coding dirty ones out there too that fit my description of them.

Lysis:

I'm sure there will be plenty of people who will tell me about the few Injuns they know who are really goood good coderz!!!!1!!!  We all know that stereotype comes from truth.  Using your scenario, you do realize that outside of those few Injuns you have interacted with that there are millions of crappy coding dirty ones out there too that fit my description of them.

 Perhaps, but I have the ability to not be a total douchbag about it.

Jonathan Holland:

No need to be racist. I've worked with some excellent indian programmers. The good ones come here. The crappy ones tend to stay there.

Here is my fix:

 var zipCodebtnAjaxContinue = document.getElementById('zipCode_btnAjaxContinue');
                   
                    if (zipCodebtnAjaxContinue)
                    {
                        zipCodebtnAjaxContinue.onClick = CheckZipClick();
                    }

Might want to remove the parentheses after CheckZipClick there. If I'm not mistaken, your current solution assigns the result of the evaluation of the function CheckZipClick to the onClick event handler, rather than the function itself.

Yeah, actually I typed that into this editor here. The actual code fix I used replaced CheckZipClick with an anonymous function closure.

 ie:

zipCodebtnAjaxContinue.onclick = function () 

{

// Do the zipcode stuff. 

} ;

Lysis:

I'm sure there will be plenty of people who will tell me about the few Injuns they know who are really goood good coderz!!!!1!!!  We all know that stereotype comes from truth.  Using your scenario, you do realize that outside of those few Injuns you have interacted with that there are millions of crappy coding dirty ones out there too that fit my description of them.

Grow up

SuperousOxide:

You might as well respond to every other thread on this board with. "What do you expect from a bunch of crackers?"

That is pretty likely to happen now. Thanks for giving him the suggestion.

MasterPlanSoftware:

SuperousOxide:

You might as well respond to every other thread on this board with. "What do you expect from a bunch of crackers?"

 

That is pretty likely to happen now. Thanks for giving him the suggestion.

SuperiousOxidous has a great idea! 

SuperousOxide:

for every one of those there are a ton of crappy coding dirty Americans and Europeans as well.

  I like to refer to those people you describe as "black people." 

Lysis:

MasterPlanSoftware:

SuperousOxide:

You might as well respond to every other thread on this board with. "What do you expect from a bunch of crackers?"

 

That is pretty likely to happen now. Thanks for giving him the suggestion.

SuperiousOxidous has a great idea! 

And the point of your existence is what, exactly?

belgariontheking:

Lysis:

MasterPlanSoftware:

SuperousOxide:

You might as well respond to every other thread on this board with. "What do you expect from a bunch of crackers?"

 

That is pretty likely to happen now. Thanks for giving him the suggestion.

SuperiousOxidous has a great idea! 

 

And the point of your existence is what, exactly?

The same reason you post here? 

 TunnelRat? Is that you?

Jonathan Holland:

replace method to change attributes on a child element.

IE's particularly borked and refuses to let you change or set attributes on elements, usually at random. Doing x.setAttribute('attribute', 'value') works for some, but fails for others, while doing "x[attribute] = 'value'" works/doesn't work for yet another set. Sometimes it's just easier to rebuild the tag using innerHTML, even if it isn't "best practices". 

 setAttribute('click',somefunction);

 or 

element.onclick = somefunction;

 Works just fine in IE.

There is no excuse for this. 

Lysis:

What do you expect from a bunch of sand people?  Have you seen them attempt simple html?  I don't think they know what a close html tag is.  

<IgnoreBlatantRasicm> 

Sand people?  I didn't know people outsourced to Tusken Raiders nowadays!

</IgnoreBlatantRacism> 

You are living up to your name wise Jedi.

 Personally, when I think of India, I think of humidity, monsoon rains, and jungles...I don't think of deserts.

 Lysis, perhaps both a Political Correctness class and a Geography class should be required?

ObiWayneKenobi:

Sand people?  I didn't know people outsourced to Tusken Raiders nowadays!

Jonathan Holland:

You are living up to your name wise Jedi.

 Personally, when I think of India, I think of humidity, monsoon rains, and jungles...I don't think of deserts.

 Lysis, perhaps both a Political Correctness class and a Geography class should be required?

 I think a severe thrashing with the clue stick would be more to the point. That, or being mauled by a bear. Him/her/it and all his/her/its "grate coader" friends.